Skip to content

Standardize ConfigRegionStateMachine log messages - #18811

Merged
CRZbulabula merged 1 commit into
apache:masterfrom
d-wang-commit:config-region-update-logs
Oct 10, 2026
Merged

CRZbulabula merged 1 commit into
apache:masterfrom
d-wang-commit:config-region-update-logs

Conversation

@d-wang-commit

Copy link
Copy Markdown
Contributor

Description

Add a consistent [ConfigRegion Update] prefix to all 26 log messages in ConfigRegionStateMachine, in both English and Chinese, so ConfigRegion updates are easier to identify. Clarify leader/follower transitions, stale leadership epochs, and leader service startup/shutdown completion. Replace four concatenated messages with complete templates.

Tests

  • UT: No tests added or modified; not run.
  • IT: No tests added or modified; not run.
  • Validation: Spotless and static log-prefix/locale-parity checks passed. ConfigNode main and test sources compiled for both locales; full-reactor verification remains incomplete.

Side effects and risks

Log consumers matching exact message text may need to update their filters. Log levels, arguments, and state-machine behavior are unchanged.


This PR has:

  • been self-reviewed.

Key changed/added classes (or packages if there are too many classes) in this PR
  • ConfigRegionStateMachine: Use complete templates for four previously concatenated log messages.
  • ConfigNodeMessages (English and Chinese): Add the common prefix and clarify leadership transition messages.

Add a common [ConfigRegion Update] prefix to English and Chinese logs.
Clarify leadership transitions and replace concatenated messages with complete templates.

@CRZbulabula CRZbulabula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CRZbulabula
CRZbulabula merged commit cb0269d into apache:master Oct 10, 2026
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants